Add alphabetical order rule #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
👍 |
tests/rules/order-alphabetical.js
Outdated
There was a problem hiding this comment.
so -webkit-box-shadow orders before -moz-transition because its box-shadow?
Contributor
Author
There was a problem hiding this comment.
Yes. The order doesn't care about prefixes, so even if w is after m, the order is using b and t.
I didn't want to enforce order between prefixes of the same property.
Contributor
Author
|
I could add a second "no warning" test without prefixed properties maybe... |
src/rules/order-alphabetical.js
Outdated
Member
There was a problem hiding this comment.
Minor thing, but it's probably best to keep the quoting consistent (even though it isn't throughout the repo right now)
Contributor
Author
|
I added a "no warning" test with unprefixed properties and changed the single quotes to double ones... |
Contributor
Author
|
Any news on this feature ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule verifies that all properties of a single rule are in alphabetical order.
I know order is a serious debate. I don't want to impose it. I just think people who want to enforce order should be able to do so using awesome csslint ;-)